Workflow and README.md tweaks#44
Merged
jpogran merged 4 commits intohashicorp:mainfrom May 25, 2022
magnetikonline:workflow-readme-tweaks
Merged
Workflow and README.md tweaks#44jpogran merged 4 commits intohashicorp:mainfrom magnetikonline:workflow-readme-tweaks
README.md tweaks#44jpogran merged 4 commits intohashicorp:mainfrom
magnetikonline:workflow-readme-tweaks
Conversation
magnetikonline
commented
May 2, 2022
magnetikonline
commented
May 2, 2022
jpogran
suggested changes
May 18, 2022
Contributor
jpogran
left a comment
There was a problem hiding this comment.
Thank you for the help with the documentation! Once the inline style requests are addressed this will be good to go.
Contributor
Author
|
Hey @jpogran - thx for the considered review 👍 I think i've addressed all the comments. 😄. Ready for re-review. |
jpogran
approved these changes
May 25, 2022
Contributor
Author
|
Thanks @jpogran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #43 - noted a few little tweaks/fixes that could be made:
@v3variants and add consistentname:'s to each job step.publish.yml.README.md..gitignore.README.mdrewrites.