Simplify Group.__setitem__ code for making external link#1989
Merged
tacaswell merged 1 commit intoh5py:masterfrom Nov 15, 2021
Merged
Simplify Group.__setitem__ code for making external link#1989tacaswell merged 1 commit intoh5py:masterfrom
tacaswell merged 1 commit intoh5py:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1989 +/- ##
==========================================
- Coverage 89.90% 89.88% -0.02%
==========================================
Files 17 17
Lines 2308 2304 -4
==========================================
- Hits 2075 2071 -4
Misses 233 233
Continue to review full report at Codecov.
|
tacaswell
approved these changes
Nov 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tacaswell made the code like this in #868, to avoid a problem with imports inside functions with the
phillock held, which apparently only affected Python 2. We no longer support Python 2, and thefilename_encodefunction can no longer import anything, so I think this can safely be changed back to the simpler code now.