Skip to content

Support PHP 8.1#2929

Merged
Nyholm merged 1 commit intomasterfrom
php-81
Sep 5, 2021
Merged

Support PHP 8.1#2929
Nyholm merged 1 commit intomasterfrom
php-81

Conversation

@GrahamCampbell
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you!

@Nyholm Nyholm merged commit 815dae7 into master Sep 5, 2021
@GrahamCampbell GrahamCampbell deleted the php-81 branch September 5, 2021 19:12
@driesvints
Copy link
Copy Markdown

Hey @GrahamCampbell @Nyholm. Can we get these changes tagged? Thanks!

@GrahamCampbell
Copy link
Copy Markdown
Member Author

Waiting on a tag on the psr7 library, first. Still a PR over there that needs to be merged.

@driesvints
Copy link
Copy Markdown

Which PR?

@Nyholm
Copy link
Copy Markdown
Member

Nyholm commented Oct 7, 2021

We will prepare a new minor release. I dont see anything blocking anymore

@GrahamCampbell
Copy link
Copy Markdown
Member Author

"just" need to write a change log. :P

@herman-aka-wouter
Copy link
Copy Markdown

@Nyholm can we merge the changes also in Guzzle 6.x?

src/Handler/MockHandler.php.

PHP Fatal error:  Uncaught Symfony\Component\ErrorHandler\Error\FatalError: Error: During inheritance of Countable: Uncaught Behat\Testwork\Call\Exception\CallErrorException: 8192: Return type of GuzzleHttp\Handler\MockHandler::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /app/vendor/guzzlehttp/guzzle/src/Handler/MockHandler.php line 173

We have our WMS still at Guzzle6 6.5.8
But we are almost ready to go to PHP8.1.

But upgrading to guzzle7 is not possilble at the moment, given we are waiting on several third party repos to implement 7 as well.
(like swagger-api/swagger-codegen#11123)

herman-aka-wouter added a commit to herman-aka-wouter/guzzle that referenced this pull request Jul 26, 2022
@GrahamCampbell
Copy link
Copy Markdown
Member Author

No. Guzzle 6 does not support PHP 8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants