Revert "Build with System OpenSSL on Mac OS arm64 (#31096)"#31739
Merged
gnossen merged 1 commit intogrpc:v1.51.xfrom Nov 22, 2022
Merged
Revert "Build with System OpenSSL on Mac OS arm64 (#31096)"#31739gnossen merged 1 commit intogrpc:v1.51.xfrom
gnossen merged 1 commit intogrpc:v1.51.xfrom
Conversation
This reverts commit b3d9833.
XuanWang-Amos
approved these changes
Nov 22, 2022
jtattermusch
added a commit
that referenced
this pull request
Jan 11, 2023
* Bump v1.51.x to 1.51.0-pre1 (#31622) * bump version to 1.51.0-pre1 * regenerate projects * Branch 1.51.x: Cherrypick "Adding token url validation cases for psc endpoints #31616" and "Added url validation for aws metadata endpoints in aws external account #31626" (#31646) * Adding token url validation cases for psc endpoints (#31616) * Adding validation case for psc endpoint * formatting fix * Added url validation for aws metadata endpoints in aws external account (#31626) * Added url validation for aws metadata endpoints in aws external account * addressing review comments * fix error message back * Fix broken test * xds resolver: fix edge cases in interactions between LDS and RDS (#31668) (#31672) * xds resolver: fix edge cases in interactions between LDS and RDS * improve SwitchFromInlineRouteConfigToRds test * clang-tidy * Automated change: Fix sanity tests Co-authored-by: markdroth <markdroth@users.noreply.github.com> Co-authored-by: markdroth <markdroth@users.noreply.github.com> * xDS: fix crash on wrong listener type (both client and server side) (#31684) (#31691) * xds resolver: fix crash on wrong listener type * fix same bug on server side * fix clang-tidy and add requested TODO * Bump v1.51.x to v1.51.0 (#31705) * bump version to 1.51.0 * regenerate projects * Revert "Build with System OpenSSL on Mac OS arm64 (#31096)" (#31739) This reverts commit b3d9833. * Bump v1.51.x to 1.51.1 (#31740) * Bump to 1.51.1 * Regenerate projects Co-authored-by: Richard Belleville <rbellevi@google.com> Co-authored-by: aeitzman <12433791+aeitzman@users.noreply.github.com> Co-authored-by: Mark D. Roth <roth@google.com> Co-authored-by: markdroth <markdroth@users.noreply.github.com>
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
* Bump v1.51.x to 1.51.0-pre1 (#31622) * bump version to 1.51.0-pre1 * regenerate projects * Branch 1.51.x: Cherrypick "Adding token url validation cases for psc endpoints #31616" and "Added url validation for aws metadata endpoints in aws external account #31626" (#31646) * Adding token url validation cases for psc endpoints (#31616) * Adding validation case for psc endpoint * formatting fix * Added url validation for aws metadata endpoints in aws external account (#31626) * Added url validation for aws metadata endpoints in aws external account * addressing review comments * fix error message back * Fix broken test * xds resolver: fix edge cases in interactions between LDS and RDS (#31668) (#31672) * xds resolver: fix edge cases in interactions between LDS and RDS * improve SwitchFromInlineRouteConfigToRds test * clang-tidy * Automated change: Fix sanity tests Co-authored-by: markdroth <markdroth@users.noreply.github.com> Co-authored-by: markdroth <markdroth@users.noreply.github.com> * xDS: fix crash on wrong listener type (both client and server side) (#31684) (#31691) * xds resolver: fix crash on wrong listener type * fix same bug on server side * fix clang-tidy and add requested TODO * Bump v1.51.x to v1.51.0 (#31705) * bump version to 1.51.0 * regenerate projects * Revert "Build with System OpenSSL on Mac OS arm64 (#31096)" (#31739) This reverts commit b3d9833. * Bump v1.51.x to 1.51.1 (#31740) * Bump to 1.51.1 * Regenerate projects Co-authored-by: Richard Belleville <rbellevi@google.com> Co-authored-by: aeitzman <12433791+aeitzman@users.noreply.github.com> Co-authored-by: Mark D. Roth <roth@google.com> Co-authored-by: markdroth <markdroth@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #31096 due to #31737. It seems many people actually were successfully using boringssl on M1 and they viewed the new default dependency on openssl as a regression.