Fix OutputOptions and GrpcOutputOptions (issue #25950)#30410
Merged
jtattermusch merged 1 commit intogrpc:masterfrom Aug 17, 2022
Merged
Conversation
Contributor
|
CC @JamesNK |
jtattermusch
approved these changes
Aug 17, 2022
Contributor
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix.
We should think about how to improve the current test suite for Grpc.Tools so that we can reliably test changes like this and we don't have to rely on manual testing (which is unrealiable and timeconsuming).
Contributor
|
CC @apolcyn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for OutputOptions and GrpcOutputOptions being ignored - issue #25950
The Grpc.Tools msbuild XML needed updating to include using the user-supplied options.