RetryFilter: Cleanup pending byte stream#29245
Merged
yashykt merged 2 commits intogrpc:masterfrom Apr 1, 2022
Merged
Conversation
Member
Author
|
As a quick experiment, I tried out #29263 to not wait on the ByteStream being cleared out before we invoke I think we should be able to fix it if we change our surface to always wait for recv_message ops to complete and the byte stream to be read before completing the recv_status op, but this change seems easier. |
markdroth
reviewed
Mar 31, 2022
Member
Author
|
Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the memory leak observed in internal bug b/226254012