Remove C# Legacy (a.k.a. "Classic") csproj example#29102
Merged
jtattermusch merged 2 commits intogrpc:masterfrom Mar 16, 2022
Merged
Remove C# Legacy (a.k.a. "Classic") csproj example#29102jtattermusch merged 2 commits intogrpc:masterfrom
jtattermusch merged 2 commits intogrpc:masterfrom
Conversation
apolcyn
approved these changes
Mar 16, 2022
anicr7
pushed a commit
to anicr7/grpc
that referenced
this pull request
Apr 1, 2022
* remove C# legacy csproj example * update BUILD-INTEGRATION.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new and simpler .NET SDK .csproj format is supported starting from VS2017, so the "old" (aka "classic") .csproj format is quite useless today. gRPC would still work for projects in the legacy .csproj format, but there's probably no need to provide and example.
Also the keeping the dependencies up to date in the legacy csproj example is quite painful due to the dependency versions showing up in multiple unexpected places in the project. See e.g. 1015689
https://github.com/grpc/grpc.io/blob/e55f596f83edd55fd3b458286fc228bfcf0bc011/content/en/docs/languages/csharp/quickstart.md?plain=1#L60