Revert "Revert "[objc] GRPCMetadataDictionary convenient typedef""#27882
Revert "Revert "[objc] GRPCMetadataDictionary convenient typedef""#27882
Conversation
|
internal TGP train check all pass, this one ready to re-land, thanks |
1901b2d to
011ce1a
Compare
sampajano
left a comment
There was a problem hiding this comment.
Thanks Denny. Comments inline :)
| @end | ||
|
|
||
| /** gRPC metadata dictionary typedef */ | ||
| typedef NSDictionary<NSString*, id<NSCopying>> GRPCMetadataDictionary; |
There was a problem hiding this comment.
Changing id -> id<NSCopying> would potentially break some 3rd party users, is that right? Is this change totally necessary?
There was a problem hiding this comment.
updating this to id to avoid breaking changes in the API.
| @@ -279,7 +279,7 @@ NS_ASSUME_NONNULL_BEGIN | |||
| * Dictionary key is of type NSString, value should be either NSString or NSData containing binary | |||
There was a problem hiding this comment.
Consider moving 2 similar comments to GRPCMetadataDictionary?
There was a problem hiding this comment.
thanks. this part is specific to initialMetadata (either NSString // NSData for the value type). GRPCMetadataDictionary are the more generic definition which also need to apply to e.g. additionalChannelArgs.
There was a problem hiding this comment.
ohh i see! Thanks for clarification! :)
011ce1a to
bc77067
Compare
Reverts #27877