Fix python tests on kokoro macos monterey#31126
Merged
jtattermusch merged 4 commits intogrpc:masterfrom Oct 10, 2022
Merged
Conversation
88036ba to
2710d52
Compare
94d918a to
5a09ac3
Compare
5c6dbe5 to
bdfd6eb
Compare
gnossen
approved these changes
Oct 10, 2022
veblush
pushed a commit
to veblush/grpc
that referenced
this pull request
Oct 11, 2022
* fix python build on kokoro macos monterey * avoid using realpath * fix grpc_distribtests_python on macos monterey * try upgrade setuptools
veblush
added a commit
that referenced
this pull request
Oct 11, 2022
apolcyn
pushed a commit
to apolcyn/grpc
that referenced
this pull request
Nov 18, 2022
* fix python build on kokoro macos monterey * avoid using realpath * fix grpc_distribtests_python on macos monterey * try upgrade setuptools
veblush
pushed a commit
that referenced
this pull request
Dec 7, 2022
ctiller
pushed a commit
that referenced
this pull request
Jan 3, 2023
* fix python build on kokoro macos monterey * avoid using realpath * fix grpc_distribtests_python on macos monterey * try upgrade setuptools * remove python2.7 from grpc_build_artifacts.sh as well * python3.11 not needed yet for the backport * stop building python3.6 wheel on macos
drfloob
pushed a commit
to drfloob/grpc
that referenced
this pull request
Jan 26, 2023
…1126) * fix python build on kokoro macos monterey * avoid using realpath * fix grpc_distribtests_python on macos monterey * try upgrade setuptools
yashykt
pushed a commit
that referenced
this pull request
Jan 31, 2023
#32217) * [backport][v1.48.x] Fix python tests on kokoro macos monterey (#31126) * fix python build on kokoro macos monterey * avoid using realpath * fix grpc_distribtests_python on macos monterey * try upgrade setuptools * install required python versions * mac does not have 3.6 * rm python36 from artifact targets and prepare_build * fix unused variable warning/error on macos * fix unused param on iOS builds --------- Co-authored-by: Jan Tattermusch <jtattermusch@google.com>
gnossen
pushed a commit
to gnossen/grpc
that referenced
this pull request
Feb 27, 2023
* fix python build on kokoro macos monterey * avoid using realpath * fix grpc_distribtests_python on macos monterey * try upgrade setuptools
veblush
pushed a commit
that referenced
this pull request
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure python MacOS basictests and distribtests work fine both on kokoro macos mojave workers (currently in use) and on kokoro monterey workers. I tested using kokoro ephemeral builds to make sure the jobs on monterey will be green.
Note that there are many places in our dockerfiles where virtualenv gets installed (and sometimes it gets pinned to a specific version), but based on my investigation, these occurrences are orthogonal to building&running grpc python basictests and building python artifacts (it's e.g. sanity, dependencies for xds test harness, some distribtests,...), so there seems to be no need to upgrade all those dockerfiles in this PR - in fact some cleanup has already been done in #31139.