EventEngine: fix callers of Run() and RunAfter() to create ExecCtx#31047
Merged
veblush merged 1 commit intogrpc:masterfrom Sep 20, 2022
Merged
EventEngine: fix callers of Run() and RunAfter() to create ExecCtx#31047veblush merged 1 commit intogrpc:masterfrom
veblush merged 1 commit intogrpc:masterfrom
Conversation
Closed
Member
|
Interesting. I was hoping that any missing, necessary exec_ctx instances would be ... less subtle than this. We had discussed trying to avoid a blanket policy to add them to every callback. I'm not sure they're needed in all of these cases, but we aren't paying a huge price to add them, so I'm ok with it. |
drfloob
approved these changes
Sep 19, 2022
Member
Author
|
I don't think we can assume that the I don't think we can start removing |
ctiller
approved these changes
Sep 19, 2022
veblush
pushed a commit
to veblush/grpc
that referenced
this pull request
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in #31041.
Given the number of places we missed this, I think we may want to consider adding some sort of test to ensure that all callers of
Run()orRunAt()will create their ownExecCtx.CC @ctiller @veblush