Add support for additional bios settings fields in Ironic#2174
Add support for additional bios settings fields in Ironic#2174jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
|
Build failed.
|
|
this probably depends on the focal update? #2169 |
|
/retest |
|
recheck |
|
This PR will need to be rebased off of master in order to take advantage of the recently fixed tests. However, since there aren't any acceptance tests in this PR, nothing will really be tested, so it's kind of moot. |
|
|
||
| func getBoolPointer(x bool) *bool { | ||
| return &x | ||
| } |
There was a problem hiding this comment.
There are a few existing ways of handling this:
- There's some existing helper code here: openstack/identity/v3/users/testing/requests_test.go
- Just declare the variables each time:
I can't recall why there aren't central helper functions in the testhelper package. I have a feeling that, for whatever reason, it was discouraged to do this in Golang in general and to instead manually declare every occurrence of pointers, but it's been too long for me to remember at this point.
There was a problem hiding this comment.
Thank you. I changed to use the variables.
|
Build failed.
|
For gophercloud#2166 A recent change to Ironic (https://review.opendev.org/c/openstack/ironic/+/786707) has added support for bios registry fields in the Ironic API. These can be retrieved using the `?detail=True` option.
|
Build failed.
|
For #2166
A recent change to Ironic
(https://review.opendev.org/c/openstack/ironic/+/786707) has added
support for bios registry fields in the Ironic API for microversion 1.74.
These can be retrieved using the
?detail=Trueoption when listingall settings. The fields are also included when getting individual
settings without any options.