Add missing bios interface fields to Ironic API#2164
Add missing bios interface fields to Ironic API#2164jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
|
Build failed.
|
|
@bfournie Thank you for submitting this. The OpenLab failure can be ignored - it looks like an issue with OpenLab itself. It looks like you need to run |
d96bdb4 to
c135730
Compare
Thank you. Yes, I forgot to run |
|
Build failed.
|
The bios interface fields are in the Ironic API but were missing from the Ironic API documentation and not included in gophercloud. This change adds in the bios interface to the node create, node list, and node driver validation APIs. For reference, these are the Ironic updates to the api-ref documentation: https://review.opendev.org/c/openstack/ironic/+/757353 https://review.opendev.org/c/openstack/ironic/+/791493 https://review.opendev.org/c/openstack/ironic/+/792210
c135730 to
fefddf5
Compare
|
Build failed.
|
|
I think this is safe to merge without the OpenLab test passing - I don't think this field would end up causing an error. However, if it does, we'll get it fixed quickly. Thanks again for working on this. |
Thank you |
A few bios interface fields are in the Ironic API but were missing from
the Ironic API documentation and not included in gophercloud. This
change adds in the bios interface to the node create, node list,
and node driver validation APIs.
For #[2163]
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L143
https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L1225
https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/utils.py#L1262