Skip to content

blockstoragev3: support extra_spec for volumetypes#2123

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
nikParasyr:vt_extra_specs
Mar 10, 2021
Merged

blockstoragev3: support extra_spec for volumetypes#2123
jtopjian merged 1 commit intogophercloud:masterfrom
nikParasyr:vt_extra_specs

Conversation

@nikParasyr
Copy link
Copy Markdown
Contributor

Add support for blockstoragev3 volumetype extra_spec operations
such as:

  • create extra specs for volume type
  • list all extra specs of volume type
  • get specific extra spec of volume type
  • update specific extra spec of volume type
  • delete specific extra spec of volume type

For #649

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

CreateExtraSpecs:

ListExtraSpecs:

GetExtraSpec:

UpdateExtraSpec:

DeleteExtraSpec:

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 2, 2021

Coverage Status

Coverage increased (+0.02%) to 79.851% when pulling fb1cbde on nikParasyr:vt_extra_specs into bcd179f on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 2, 2021

Build failed.

@nikParasyr
Copy link
Copy Markdown
Contributor Author

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 2, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 8, 2021

Build failed.

Add support for blockstoragev3 volumetype extra_spec operations
such as:
- create extra specs for volume type
- list all extra specs of volume type
- get specific extra spec of volume type
- update specific extra spec of volume type
- delete specific extra spec of volume type
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 8, 2021

Build succeeded.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Mar 9, 2021

@nikParasyr This looks good to me. Are you finished working on this?

@nikParasyr
Copy link
Copy Markdown
Contributor Author

@jtopjian yes, this can be merged from my side

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 3dc4bb8 into gophercloud:master Mar 10, 2021
@nikParasyr nikParasyr deleted the vt_extra_specs branch March 16, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants