Skip to content

heat/stack support show hidden option#2104

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
es-container:stack
Apr 16, 2021
Merged

heat/stack support show hidden option#2104
jtopjian merged 1 commit intogophercloud:masterfrom
es-container:stack

Conversation

@yylt
Copy link
Copy Markdown
Contributor

@yylt yylt commented Jan 29, 2021 •
edited by jtopjian
Loading

For #2142

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://github.com/openstack/heat/blob/bfbaab107d709c37548a22239b952c6221b9ac85/heat/api/openstack/v1/stacks.py#L236

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 29, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 79.788% when pulling 6f8d397 on es-container:stack into 7d4ec67 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 29, 2021

Build succeeded.

@yylt
Copy link
Copy Markdown
Contributor Author

yylt commented Apr 15, 2021

@jtopjian this is ready

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Apr 16, 2021

@yylt When you submitted this PR, the following message was displayed:

Prior to starting a PR, please make sure you have read our
contributor tutorial.

Prior to a PR being reviewed, there needs to be a Github issue that the PR
addresses. Replace the brackets and text below with that issue number.

For #[PUT ISSUE NUMBER HERE]

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

[PUT URLS HERE]

None of the instructions were followed and so that is why this PR was never reviewed.

I have opened Issue #2142 on your behalf.

Please consider following these instructions next time, as it helps the project more quickly validate pull requests. Please let me know if you have any questions.

jtopjian
jtopjian approved these changes Apr 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you

@jtopjian jtopjian merged commit 315f233 into gophercloud:master Apr 16, 2021
@jtopjian jtopjian mentioned this pull request Apr 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yylt @coveralls @jtopjian