test: drop old databases from instance before running integration tests.#1861
Merged
rajatbhatta merged 8 commits intogoogleapis:mainfrom Apr 29, 2022
Merged
test: drop old databases from instance before running integration tests.#1861rajatbhatta merged 8 commits intogoogleapis:mainfrom
rajatbhatta merged 8 commits intogoogleapis:mainfrom
Conversation
This commit aims to resolve the RESOURCE_EXHAUSTED errors due to number of databases in an instance reaching the maximum limit.
olavloite
reviewed
Apr 29, 2022
google-cloud-spanner/src/test/java/com/google/cloud/spanner/IntegrationTestEnv.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/IntegrationTestEnv.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/IntegrationTestEnv.java
Show resolved
Hide resolved
…tegrationTestEnv.java Co-authored-by: Knut Olav Løite <koloite@gmail.com>
olavloite
approved these changes
Apr 29, 2022
Collaborator
olavloite
left a comment
There was a problem hiding this comment.
LGTM (once the linting build error is fixed)
This was referenced May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit aims to resolve the RESOURCE_EXHAUSTED errors due to
number of databases in an instance reaching the maximum limit.
We delete all the databases of an instance, which are more than 24 hours old, before running the tests.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1832 ☕️