feat: support CREATE DATABASE in Connection API#1845
Merged
Conversation
Adds support for the CREATE DATABASE statement in the Connection API. The statement can only be used with a SingleUseTransaction (i.e. auto commit mode). It is not supported in DDL batches. The database that is created will have the same dialect as the current database that the user is connected to. Fixes #1884
ansh0l
approved these changes
Apr 27, 2022
Contributor
ansh0l
left a comment
There was a problem hiding this comment.
LGTM with a query, please take a look
| Iterable<String> statements) | ||
| throws SpannerException { | ||
| throw new UnsupportedOperationException("Unimplemented"); | ||
| } |
Contributor
There was a problem hiding this comment.
We seem to be throwing SpannerException elsewhere with createDatabase in the interface. Why is it an UnsupportedOperationException("Unimplemented"); for this one?
Collaborator
Author
There was a problem hiding this comment.
This is only to make this a non-breaking change. We add this when we add a new method to a public interface. This prevents compile errors for downstream users that might implement this interface in a test, as the method has a default implementation. See for example this example from the DatabaseClient where we did the same thing:
rahul2393
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the CREATE DATABASE statement in the Connection API.
The statement can only be used with a
SingleUseTransaction(i.e. autocommit mode). It is not supported in DDL batches. The database that is
created will have the same dialect as the current database that the user
is connected to.
Fixes #1844
Towards b/229420558