feat: Copy backup samples by asthamohta · Pull Request #1802 · googleapis/java-spanner

asthamohta · 2022-04-04T05:08:28Z

Adding the following samples for Copy Backup:

Copy Backup from source database
Use max expire time for backups
Get database options for copy backup

snippet-bot · 2022-04-04T05:08:32Z

Here is the summary of changes.

You are about to add 1 region tag.

samples/snippets/src/main/java/com/example/spanner/CopyBackupSample.java:19, tag spanner_copy_backup

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

olavloite

There's no integration test for the CopyBackup sample. Is that intentional?

samples/snippets/src/main/java/com/example/spanner/CopyBackupSample.java

samples/snippets/src/main/java/com/example/spanner/SpannerSample.java

samples/snippets/src/test/java/com/example/spanner/SpannerSampleIT.java

asthamohta · 2022-04-05T05:33:43Z

@olavloite yes, because I notices not all samples have an IT and this is a very long running function so decided to go with this

samples/snippets/src/test/java/com/example/spanner/SpannerSampleIT.java

samples/snippets/src/main/java/com/example/spanner/CopyBackupSample.java

thiagotnunes · 2022-04-05T05:41:20Z

samples/snippets/src/main/java/com/example/spanner/SpannerSample.java


  // [START spanner_list_backup_operations]
-  static void listBackupOperations(InstanceAdminClient instanceAdminClient, DatabaseId databaseId) {
+  static void listBackupOperations(


Isn't this a breaking change? Maybe customers won't care because it is in the sample , but I don't know what the policy is here. Yoshi team might know

@olavloite pointed out that this is a non public method and hence can't be called so this will not be a breaking change

That is true, but we publish these samples in our public documentation, so we would be changing the signature. Anyway, if your team is ok with this, I am ok.

ansh0l · 2022-04-11T17:59:32Z

@asthamohta : can you update the PR to provide the description in the right format?

ansh0l

Update the PR description

thiagotnunes · 2022-04-22T01:47:01Z

README.md


 ```Scala
-libraryDependencies += "com.google.cloud" % "google-cloud-spanner" % "6.23.0"
+libraryDependencies += "com.google.cloud" % "google-cloud-spanner" % "6.23.2"


nit: I don't think these version updates should be part of this PR

So I didn't do this. After I raised the PR, the changes in this file came automatically after I raised the PR. I only changes the install-without-bom. I'll try merging the other PR with the version change and remove these files

thiagotnunes · 2022-04-22T01:48:36Z

google-cloud-spanner/pom.xml

      <groupId>org.openjdk.jmh</groupId>
      <artifactId>jmh-core</artifactId>
-      <version>1.34</version>
+      <version>1.35</version>


This should happen automatically no? Why do we need to update jmh here?

thiagotnunes · 2022-04-22T01:48:50Z

samples/install-without-bom/pom.xml

      <groupId>com.google.cloud</groupId>
      <artifactId>google-cloud-spanner</artifactId>
-      <version>6.21.2</version>
+      <version>6.23.2</version>


This is already part of this PR: https://github.com/googleapis/java-spanner/pull/1788/files

thiagotnunes · 2022-04-22T01:49:15Z

samples/snippets/pom.xml

        <groupId>com.google.cloud</groupId>
        <artifactId>libraries-bom</artifactId>
-        <version>25.0.0</version>
+        <version>25.1.0</version>


This should happen automatically in another PR (from dependabot)

thiagotnunes · 2022-04-22T01:50:57Z

samples/snippets/src/main/java/com/example/spanner/SpannerSample.java


  // [START spanner_list_backup_operations]
-  static void listBackupOperations(InstanceAdminClient instanceAdminClient, DatabaseId databaseId) {
+  static void listBackupOperations(


That is true, but we publish these samples in our public documentation, so we would be changing the signature. Anyway, if your team is ok with this, I am ok.

This reverts commit b06a3df.

…le.java Co-authored-by: Knut Olav Løite <koloite@gmail.com>

…ample.java Co-authored-by: Knut Olav Løite <koloite@gmail.com>

This reverts commit cdf4d17.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

olavloite · 2022-04-22T07:40:08Z

samples/snippets/src/main/java/com/example/spanner/SpannerSample.java

-            OffsetDateTime.now().getOffset()).toString()));
+          expireTime.getSeconds(),
+          expireTime.getNanos(),
+          OffsetDateTime.now().getOffset()).toString()));


super nit: the .toString() is superfluous

Done

asthamohta requested a review from a team April 4, 2022 05:08

product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Apr 4, 2022

product-auto-label bot added the samples Issues that are directly related to samples. label Apr 4, 2022

blunderbuss-gcf bot assigned kolea2 Apr 4, 2022

asthamohta force-pushed the copy-backup-samples branch from c370f35 to e6d042b Compare April 4, 2022 10:37

asthamohta requested review from olavloite and thiagotnunes April 4, 2022 11:00

ansh0l unassigned kolea2 Apr 4, 2022

olavloite reviewed Apr 5, 2022

View reviewed changes

thiagotnunes reviewed Apr 5, 2022

View reviewed changes

ansh0l previously requested changes Apr 11, 2022

View reviewed changes

asthamohta requested a review from a team April 21, 2022 06:12

product-auto-label bot added the size: m Pull request size is medium. label Apr 21, 2022

asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 21, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 21, 2022

asthamohta force-pushed the copy-backup-samples branch from f36e29f to 474dfa8 Compare April 21, 2022 08:59

asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 21, 2022

asthamohta requested a review from thiagotnunes April 21, 2022 10:14

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 21, 2022

asthamohta requested review from ansh0l and olavloite April 21, 2022 10:14

thiagotnunes reviewed Apr 22, 2022

View reviewed changes

asthamohta added 5 commits April 22, 2022 12:03

Revert "removing samples"

cbc0e65

This reverts commit b06a3df.

removing samples

ede01f2

changes to samples

1e983da

linting

44ff9d1

changes as per comments

1c76896

asthamohta and others added 7 commits April 22, 2022 12:03

Update samples/snippets/src/main/java/com/example/spanner/SpannerSamp…

b02cdf1

…le.java Co-authored-by: Knut Olav Løite <koloite@gmail.com>

Update samples/snippets/src/main/java/com/example/spanner/CopyBackupS…

50f18da

…ample.java Co-authored-by: Knut Olav Løite <koloite@gmail.com>

don't merge

8917d66

Revert "don't merge"

bb39c9f

This reverts commit cdf4d17.

linting

a3139b0

🦉 Updates from OwlBot post-processor

885c9a6

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

linting

0920a95

product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 22, 2022

asthamohta force-pushed the copy-backup-samples branch from d9d234b to 0920a95 Compare April 22, 2022 06:39

product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Apr 22, 2022

asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 22, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 22, 2022

🦉 Updates from OwlBot post-processor

3c14217

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

olavloite approved these changes Apr 22, 2022

View reviewed changes

blunderbuss-gcf bot assigned prash-mi Apr 22, 2022

asthamohta merged commit 787ccad into googleapis:main Apr 22, 2022

release-please bot mentioned this pull request Apr 22, 2022

chore(main): release 6.24.0 #1846

Merged

Conversation

asthamohta commented Apr 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snippet-bot bot commented Apr 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

olavloite left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asthamohta commented Apr 5, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ansh0l commented Apr 11, 2022

Uh oh!

ansh0l left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

asthamohta commented Apr 4, 2022 •

edited

Loading

snippet-bot bot commented Apr 4, 2022 •

edited

Loading