feat: Copy Backup Support#1778
Merged
asthamohta merged 21 commits intogoogleapis:mainfrom Mar 28, 2022
Merged
Conversation
|
Warning: This pull request is touching the following templated files:
|
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
48d840d to
2d627aa
Compare
Contributor
thiagotnunes
left a comment
There was a problem hiding this comment.
Be careful when accepting my code suggestions, as you need to change the commit title, otherwise the conventionalcommits check will fail. Feel free to, instead of accepting the suggestions, implementing the same in your local machine.
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java
Outdated
Show resolved
Hide resolved
| * | ||
| * <p>Returns the names of the destination backups being created by copying this source backup. | ||
| */ | ||
| protected abstract Builder setReferencingBackup(ProtocolStringList referencingBackup); |
Contributor
There was a problem hiding this comment.
We should not use the protobuf specific types here. Instead of ProtocolStringList, could you use List<String>?
google-cloud-spanner/src/test/java/com/google/cloud/spanner/BackupTest.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SpannerRpc.java
Outdated
Show resolved
Hide resolved
thiagotnunes
suggested changes
Mar 25, 2022
Contributor
thiagotnunes
left a comment
There was a problem hiding this comment.
We need to resolve the breaking changes, populate the new fields when reading the proto and remove the samples
a28dc35 to
10d2134
Compare
10d2134 to
b06a3df
Compare
olavloite
approved these changes
Mar 25, 2022
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SpannerRpc.java
Show resolved
Hide resolved
rajatbhatta
reviewed
Mar 25, 2022
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java
Outdated
Show resolved
Hide resolved
a4d44b2 to
809465c
Compare
rajatbhatta
approved these changes
Mar 25, 2022
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SpannerRpc.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/BackupTest.java
Outdated
Show resolved
Hide resolved
| .setDatabase(DatabaseId.of(proto.getDatabase())) | ||
| .setEncryptionInfo(EncryptionInfo.fromProtoOrNull(proto.getEncryptionInfo())) | ||
| .setProto(proto) | ||
| .setMaxExpireTime(Timestamp.fromProto(proto.getMaxExpireTime())) |
Contributor
There was a problem hiding this comment.
Did we test with null max expire time and null referencingBackupsList?
Contributor
Author
There was a problem hiding this comment.
We won't get a null value over here. The addAll function checks for non null values-> https://github.com/protocolbuffers/protobuf/blob/master/java/core/src/main/java/com/google/protobuf/AbstractMessageLite.java#L408
Contributor
thiagotnunes
left a comment
There was a problem hiding this comment.
I will remove my request changes so you are not blocked by my review, but please address the method name change
thiagotnunes
approved these changes
Mar 25, 2022
cfc43a8 to
a968222
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.