chore: update rowset sharding to use split points as start keys#1218
Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom Apr 14, 2022
Merged
chore: update rowset sharding to use split points as start keys#1218gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
Conversation
mutianf
approved these changes
Apr 1, 2022
Change-Id: I148c508de1abf43ebf6ecd0933cc3f13d9fa7fb4
f97e905 to
c55577d
Compare
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
mpeddada1
pushed a commit
that referenced
this pull request
Apr 22, 2022
RowSetUtil has 2 methods to split a RowSet: split and shard. Split is used for ReadRows resumption, so the split needs to be included in the segment. Shard is used for map/reduce style frameworks to parallelize the work. In this case the split points should be treated as start keys (since they usually come from SampleRowKeys and align with the start of a tablet. This PR fixes the shard behavior to use splits as start keys. It introduces some code duplication but overall makes it easier to reason about the 2 behaviors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RowSetUtil has 2 methods to split a RowSet: split and shard.
Split is used for ReadRows resumption, so the split needs to be included in the segment.
Shard is used for map/reduce style frameworks to parallelize the work. In this case the split points should be treated as start keys (since they usually come from SampleRowKeys and align with the start of a tablet. This PR fixes the shard behavior to use splits as start keys. It introduces some code duplication but overall makes it easier to reason about the 2 behaviors