refactor(bigquery/storage/managedwriter): add custom client options#7490
Merged
shollyman merged 3 commits intogoogleapis:mainfrom Feb 27, 2023
Merged
refactor(bigquery/storage/managedwriter): add custom client options#7490shollyman merged 3 commits intogoogleapis:mainfrom
shollyman merged 3 commits intogoogleapis:mainfrom
Conversation
This PR revisits the expected behavior for config knobs in the client. Previously, all configuration was done when instantiating a writer (aka a ManagedStream). There are some chicken-and-egg problems related to multiplex settings, as connection options are decoupled from individual writers. This PR adds the following unexported custom client options (but does not yet use them for anything): * enableMultiplex * defaultInflightRequests * defaultInflightBytes * defaultAppendRowsCallOption This PR also removes the still-unexported enableMultiplex from the set of defined WriterOption options which can be passed when instantiating individual writes. Towards: googleapis#7103
Contributor
Author
|
build failure is unrelated, something about documentai samples appears be having issues? |
alvarowolfx
approved these changes
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revisits the expected behavior for config knobs in the client. Previously, all configuration was done when instantiating a writer (aka a ManagedStream). There are some chicken-and-egg problems related to multiplex settings, as connection options are decoupled from individual writers.
This PR adds the following unexported custom client options (but does not yet use them for anything):
This PR also removes the still-unexported enableMultiplex from the set of defined WriterOption options which can be passed when instantiating individual writes.
Additionally, this refactor includes a correctness fix for the traceID option that was causing the traceID to duplicate the initial token.
Towards: #7103