Skip to content

chore(storage): fix checksums for gRPC uploads#7193

Merged
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom
tritone:fix-grpc-checksum
Dec 27, 2022
Merged

chore(storage): fix checksums for gRPC uploads#7193
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom
tritone:fix-grpc-checksum

Conversation

@tritone
Copy link
Copy Markdown
Contributor

@tritone tritone commented Dec 27, 2022 •
edited
Loading

There was an API change so that checksums can now only be provided by the StartResumableUpload request rather than while uploading. Send the checksum at this stage instead.

Fixes #7033

@tritone
chore(storage): fix checksums for gRPC uploads
7b848ac 
There was an API change so that checksums can now only
be provided by the StartResumableUpload request rather than
while uploading. Send the checksum at this stage instead.
@tritone tritone requested review from a team December 27, 2022 21:58
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the Cloud Storage API. size: s Pull request size is small. and removed size: m Pull request size is medium. labels Dec 27, 2022
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 27, 2022
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Dec 27, 2022
codyoss
codyoss approved these changes Dec 27, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Dec 27, 2022
@gcf-merge-on-green gcf-merge-on-green Bot merged commit a7720e4 into googleapis:main Dec 27, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 27, 2022
tritone added a commit to tritone/google-cloud-go that referenced this pull request Dec 28, 2022
@tritone
chore(storage): fix checksum for grpc simple write
d5189d6 
In googleapis#7193 I moved the checksum logic to send on the request that
initiates the upload, but I inadvertently removed sending the
checksum for one-shot uploads. This PR restores the checksum
logic for simple uploads.

Fixes googleapis#7194
@tritone tritone mentioned this pull request Dec 28, 2022
Merged
tritone added a commit that referenced this pull request Dec 28, 2022
@tritone
chore(storage): fix checksum for grpc simple write (#7195)
3592917 
In #7193 I moved the checksum logic to send on the request that
initiates the upload, but I inadvertently removed sending the
checksum for one-shot uploads. This PR restores the checksum
logic for simple uploads.

Fixes #7194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyoss codyoss codyoss approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

storage: TestIntegration_MultiChunkWrite failed

2 participants

@tritone @codyoss