fix(storage): fix request token passing for Copier.Run#6863
Merged
tritone merged 3 commits intogoogleapis:mainfrom Oct 14, 2022
Merged
fix(storage): fix request token passing for Copier.Run#6863tritone merged 3 commits intogoogleapis:mainfrom
tritone merged 3 commits intogoogleapis:mainfrom
Conversation
tritone
reviewed
Oct 14, 2022
| return nil, err | ||
| } | ||
| c.RewriteToken = res.token | ||
| req.token = res.token |
Contributor
There was a problem hiding this comment.
You actually need to leave the update of c.RewriteToken as well -- this is an exported field of Copier and the user might use this to resume the copy if it's interrupted.
tritone
approved these changes
Oct 14, 2022
This was referenced Nov 1, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes infinite retry issues.
Will follow up with tests to catch this behaviour.
Fixes #6857