Skip to content

chore: update how we handle mod replacements#6704

Merged
codyoss merged 1 commit intogoogleapis:mainfrom
codyoss:regen-fixit
Sep 20, 2022
Merged

chore: update how we handle mod replacements#6704
codyoss merged 1 commit intogoogleapis:mainfrom
codyoss:regen-fixit

Conversation

@codyoss
Copy link
Copy Markdown
Member

@codyoss codyoss commented Sep 20, 2022

  • Add a tidy after replace. The genproto dependency is getting more complex as it now associates with many aliases. A tidy is now requried.
  • Since we are tidying we can no longer just simply drop the replace as there would have been dependency updates because of the tidy. Instead we can achive the same effect by using git restore.

- Add a tidy after replace. The genproto dependency is getting more
  complex as it now associates with many aliases. A tidy is now
  requried.
- Since we are tidying we can no longer just simply drop the replace
  as there would have been dependency updates because of the tidy.
  Instead we can achive the same effect by using git restore.
@codyoss codyoss requested a review from a team September 20, 2022 18:10
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Sep 20, 2022
Copy link
Copy Markdown
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thank you!!

@codyoss codyoss merged commit 402eb24 into googleapis:main Sep 20, 2022
@codyoss codyoss deleted the regen-fixit branch September 20, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants