Skip to content

chore(storage): parse out project number if available#6671

Merged
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom
noahdietz:parse-project-number
Sep 20, 2022
Merged

chore(storage): parse out project number if available#6671
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom
noahdietz:parse-project-number

Conversation

@noahdietz
Copy link
Copy Markdown
Contributor

The JSON API has a dedicated ProjectNumber uint64 field used to populate the same field on BucketAttrs. The gRPC API has a string project field that can contain either a project number or a project identifier (alphanumeric). Parse out the project number if it is present in the returned Bucket, otherwise leave it as 0.

@noahdietz noahdietz requested review from a team September 14, 2022 20:33
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Sep 14, 2022
@noahdietz noahdietz requested a review from tritone September 14, 2022 20:34
@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Sep 20, 2022
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 17cceeb into googleapis:main Sep 20, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 20, 2022
@noahdietz noahdietz deleted the parse-project-number branch September 20, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants