chore(internal/aliasfix): properly truncate and backup files#6637
Merged
codyoss merged 1 commit intogoogleapis:mainfrom Sep 8, 2022
Merged
chore(internal/aliasfix): properly truncate and backup files#6637codyoss merged 1 commit intogoogleapis:mainfrom
codyoss merged 1 commit intogoogleapis:mainfrom
Conversation
Member
codyoss
commented
Sep 8, 2022
- Use os.Create to truncate existing file if needed
- Use named imports to capture error
- Create a bak incase anything goes wrong. We don't want to delete peoples code :)
- Bubble up error if any from WalkDir
- Use os.Create to truncate existing file if needed - Use named imports to capture error - Create a bak incase anything goes wrong. We don't want to delete peoples code :)
noahdietz
approved these changes
Sep 8, 2022
Contributor
noahdietz
left a comment
There was a problem hiding this comment.
Cool, good idea on the bak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.