chore: remove mock_test files#6627
Merged
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom Sep 7, 2022
Merged
Conversation
These files are no longer generated and they would need to be updated during our alias migration if they were still around. I don't think they provide too much value so they are being removed.
tritone
reviewed
Sep 7, 2022
Contributor
tritone
left a comment
There was a problem hiding this comment.
I see that storage is still used and you restored it in a later commit. Should we be working to remove this dep?
noahdietz
approved these changes
Sep 7, 2022
Contributor
That was a hand-written file, whereas the ones @codyoss is trying to delete are generated files, previously created by the monolith generator. The move to microgenerator did not carry this feature over, so the files in this PR haven't been updated in a while. tl;dr: Storage mock_test.go is fine as it is. |
tritone
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files are no longer generated and they would need to be updated during our alias migration if they were still around. I don't think they provide too much value so they are being removed.