test(storage): add scenario 8 to retry conformance tests#6556
Merged
cojenco merged 13 commits intogoogleapis:mainfrom Sep 13, 2022
Merged
test(storage): add scenario 8 to retry conformance tests#6556cojenco merged 13 commits intogoogleapis:mainfrom
cojenco merged 13 commits intogoogleapis:mainfrom
Conversation
tritone
reviewed
Sep 9, 2022
Contributor
tritone
left a comment
There was a problem hiding this comment.
Overall looks good, one suggestion about how this should be factored
tritone
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds scenario 8 to test downloads can handle complex retries, per internal docs go/retry-conf-test-media-ops
method.Groupto test protoUpdate: testbench new tag released on 08/29 with googleapis/storage-testbench#397
Testcase as the following
Note: comma in the license headers had to be removed per the newly enabled header-checker-lint