feat(bigquery): add support for dataset tags#6114
Merged
shollyman merged 3 commits intogoogleapis:mainfrom Jun 13, 2022
Merged
Conversation
steffnay
approved these changes
Jun 3, 2022
This was referenced Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR plumbs through the GCP tags as part of the dataset metadata. Manipulation of tags is not done via the dataset methods, but other APIS such as cloud resource manager.
This PR doesn't include integration tests as establishing an org hierarchy and policy bindings for tags are a bit heavyweight, but I did run an example test fetching metadata from a BQ dataset where this environment is setup and confirmed the results manually.