feat(bigquery/storage/managedwriter/adapt): normalize proto3 presence#6021
Merged
shollyman merged 2 commits intogoogleapis:mainfrom May 19, 2022
Merged
feat(bigquery/storage/managedwriter/adapt): normalize proto3 presence#6021shollyman merged 2 commits intogoogleapis:mainfrom
shollyman merged 2 commits intogoogleapis:mainfrom
Conversation
This PR changes the normalizer to clear the proto3 optional presence field in the FieldDescriptorProto. The backend can treat this case as an instance of proto2 optional.
yirutang
approved these changes
May 10, 2022
Contributor
yirutang
left a comment
There was a problem hiding this comment.
LGTM, I think it would be even better if you have a e2e so that we have greater confidence that e2e it works.
Contributor
Author
#6023 will add the round trip testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the normalizer to clear the proto3 optional presence
field in the FieldDescriptorProto. The backend can treat this case
as an instance of proto2 optional.
More background information: https://github.com/protocolbuffers/protobuf/blob/main/docs/field_presence.md