test(spanner)!: fix data race in spanner integration tests#5276
test(spanner)!: fix data race in spanner integration tests#5276rahul2393 merged 2 commits intogoogleapis:mainfrom rahul2393:fix-data-race
Conversation
| ) | ||
| } | ||
|
|
||
| func GetGFELatencyMetricsFlag() bool { |
There was a problem hiding this comment.
Could this be unexported? And same for the setter?
| if !strings.HasPrefix(m[tagKeyClientID], "client") { | ||
| t.Fatalf("Incorrect client ID: %v", m[tagKeyClientID]) | ||
| } | ||
| if !strings.HasPrefix(m[tagKeyInstance], "gotest") { |
|
By the way: The build error seems to be unrelated to this change. AFAICT, it is caused by a formatting error in the unedited @codyoss It seems that #5269 introduced a formatting error that was hidden by a different build error in that PR, but that it is a formatting error that only seems to be picked up by Go 1.17. At least, if I run |
olavloite
left a comment
There was a problem hiding this comment.
If I understand it correctly, the GFE Latency feature had not yet been released. We should make sure that this change then is included in the next release, as it would otherwise be a breaking change (we are removing an exported variable).
|
No its not yet released so its safe for now to get merged in current release, here is the release PR #5219 |
|
@olavloite build passed after changing iam/go_mod_tidy_hack.go and adding the unused exported GFELatencyMetricsEnabled field back to this PR. is it good to merge now? |
Fixes #5272