This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: add token_info_url to external account credentials#1168
Merged
ScruffyProdigy merged 15 commits intogoogleapis:mainfrom Oct 27, 2022
Merged
feat: add token_info_url to external account credentials#1168ScruffyProdigy merged 15 commits intogoogleapis:mainfrom
ScruffyProdigy merged 15 commits intogoogleapis:mainfrom
Conversation
Also some minor refactoring
clundin25
reviewed
Oct 25, 2022
clundin25
reviewed
Oct 25, 2022
clundin25
reviewed
Oct 25, 2022
clundin25
reviewed
Oct 25, 2022
clundin25
reviewed
Oct 25, 2022
clundin25
reviewed
Oct 25, 2022
clundin25
reviewed
Oct 25, 2022
lsirac
approved these changes
Oct 25, 2022
aeitzman
reviewed
Oct 26, 2022
BigTailWolf
approved these changes
Oct 27, 2022
Contributor
BigTailWolf
left a comment
There was a problem hiding this comment.
LGTM. Very helpful changes. Then the pluggable auth won't be done in a dirty way.
sai-sunder-s
approved these changes
Oct 27, 2022
b7f77c6 to
53ca61d
Compare
lsirac
reviewed
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also some minor refactoring