Skip to content

test: Switch to unittest.mock#1864

Merged
parthea merged 2 commits intogoogleapis:mainfrom
s-t-e-v-e-n-k:switch-to-unittest-mock
Aug 6, 2022
Merged

test: Switch to unittest.mock#1864
parthea merged 2 commits intogoogleapis:mainfrom
s-t-e-v-e-n-k:switch-to-unittest-mock

Conversation

@s-t-e-v-e-n-k
Copy link
Copy Markdown
Contributor

As of Python 3.4, the unittest module in the standard library has
included mock, which means we can remove one external dependency.

Fixes #1863

As of Python 3.4, the unittest module in the standard library has
included mock, which means we can remove one external dependency.
@s-t-e-v-e-n-k s-t-e-v-e-n-k requested a review from a team August 3, 2022 07:02
@google-cla
Copy link
Copy Markdown

google-cla bot commented Aug 3, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 3, 2022
@parthea parthea changed the title Switch to unittest.mock test: Switch to unittest.mock Aug 6, 2022
@conventional-commit-lint-gcf
Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 6, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 6, 2022
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Aug 6, 2022

Thanks @s-t-e-v-e-n-k !

@parthea parthea merged commit 8c87a41 into googleapis:main Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop using external 'mock' dependency

3 participants