Skip to content

style: update import in docs, improve python idiomaticity#1855

Merged
parthea merged 8 commits intogoogleapis:mainfrom
amillert:amillert/samples-compute-updates
Aug 9, 2022
Merged

style: update import in docs, improve python idiomaticity#1855
parthea merged 8 commits intogoogleapis:mainfrom
amillert:amillert/samples-compute-updates

Conversation

@amillert
Copy link
Copy Markdown
Contributor

@amillert amillert commented Jul 26, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@amillert amillert requested a review from a team as a code owner July 26, 2022 11:00
@amillert amillert requested a review from atulep July 26, 2022 11:00
@google-cla
Copy link
Copy Markdown

google-cla bot commented Jul 26, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 26, 2022
@amillert amillert marked this pull request as draft July 26, 2022 11:03
@amillert amillert force-pushed the amillert/samples-compute-updates branch from f62276a to 7f80030 Compare July 26, 2022 14:57
@amillert amillert changed the title Samples Compute Updates - Docs, Idiomacity style: update import in docs, improve python idiomaticity Jul 26, 2022
@amillert amillert force-pushed the amillert/samples-compute-updates branch from 7f80030 to de54185 Compare July 26, 2022 16:25
@amillert amillert marked this pull request as ready for review July 26, 2022 16:30
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 6, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 6, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 6, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 6, 2022
@parthea parthea merged commit 5de9f1a into googleapis:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

@atulep atulep Awaiting requested review from atulep atulep is a code owner automatically assigned from googleapis/python-samples-owners

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amillert @parthea @yoshi-kokoro