Add alphanumeric param to AutolinkOptions#2450
Merged
gmlewis merged 7 commits intogoogle:masterfrom Sep 5, 2022
douglascayers:autolinks-is-alphanumeric
Merged
Add alphanumeric param to AutolinkOptions#2450gmlewis merged 7 commits intogoogle:masterfrom douglascayers:autolinks-is-alphanumeric
gmlewis merged 7 commits intogoogle:masterfrom
douglascayers:autolinks-is-alphanumeric
Conversation
The authorizations_test already checks for these env vars when needed
Codecov Report
@@ Coverage Diff @@
## master #2450 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 122 122
Lines 10690 10690
=======================================
Hits 10480 10480
Misses 144 144
Partials 66 66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gmlewis
approved these changes
Sep 1, 2022
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you very much, @douglascayers !
Looks great to me.
Awaiting second LGTM from any other contributor to this repo before merging.
Contributor
Author
|
Hi @alexal, as a contributor to the autolinks feature, I'd appreciate your review of my proposed changes. Thanks! |
douglascayers
commented
Sep 3, 2022
raynigon
approved these changes
Sep 5, 2022
Collaborator
|
Thank you, @raynigon ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2449
Changes
IsAlphanumericparam toAutolinkOptionsandAutolinkstructs ofgithub/repos_autolinks.gocreateRandomTestRepositoryfunction intest/integration/github_test.goto look up the owner to create the repo under if a name isn't specified explicitly. ChecksGITHUB_OWNERenv var else falls back to user the oauth token belongs to.initfunction oftest/integration/github_test.gobecause those checks already occur in thetest/integration/authorizations_test.gofile as needed. This made it easier for me to run integrations tests without setting env vars that weren't needed.Tests
github/repos_autolinks_test.gotest/integration/repos_test.goCreated an alphanumeric autolink
Created a numeric autolink