Add boolean baked-in validator to check a string value is a valid boolean representation#804
Merged
deankarn merged 2 commits intogo-playground:masterfrom Aug 8, 2021
xvello:feature/boolean
Merged
Add boolean baked-in validator to check a string value is a valid boolean representation#804deankarn merged 2 commits intogo-playground:masterfrom xvello:feature/boolean
boolean baked-in validator to check a string value is a valid boolean representation#804deankarn merged 2 commits intogo-playground:masterfrom
xvello:feature/boolean
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
booleanbaked-in validatorDue to technical limitations upstream, some of our structs can only have
stringfields, but some of these fields will be parsed into booleans by the business logic, usingstrconv.ParseBool:Similar to the
numericvalidator, this PR adds abooleanvalidator that checks that the field will be safely convertible to a boolean. Instead of enumerating all values currently accepted byParseBool, this PR just calls the method and confirms it does not return an error. The rationale for this is to stay in sync if the accepted values change in future versions of go.I updated the tests and documentation, but I might have forgotten something else to update.
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers