Add support for tracing via OpenTelemetry#254
Merged
casualjim merged 13 commits intogo-openapi:masterfrom Nov 28, 2022
Merged
Conversation
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
e219b88 to
bac160e
Compare
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
e5f0273 to
e390757
Compare
josephwoodward
commented
Oct 26, 2022
| attribute.String(string(semconv.HTTPMethodKey), op.Method), | ||
| attribute.String("span.kind", trace.SpanKindClient.String()), | ||
| //TODO: Figure out the best way to get the scheme? | ||
| attribute.String("http.scheme", op.Schemes[0]), |
Contributor
Author
There was a problem hiding this comment.
Hi @casualjim, can you offer any pointers on the best way to get the scheme? I don't appear to have access to the underlying http.Request object to check the existence of the TLS field (which is one common way to work out the scheme)
9a080fa to
4edfa2a
Compare
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
4edfa2a to
d09ae3b
Compare
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
Member
|
Thanks for all your work on this. |
casualjim
approved these changes
Nov 4, 2022
Member
casualjim
left a comment
There was a problem hiding this comment.
This looks good.
I'll see if I can figure out how to get the actual scheme that's being used for the request into here too.
Member
|
can you bump the go version in the .github/ folder to be at least 1.18 or higher? Otel seems to require it |
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
Contributor
Author
|
@casualjim That's been bumped, do you want me to bump the version in |
Member
|
yeah that would be good |
Signed-off-by: Joseph Woodward <joseph.woodward@xeuse.com>
|
@casualjim Could you please merge this pr if It’s ok with you. |
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 80.13% 80.20% +0.07%
==========================================
Files 42 44 +2
Lines 3191 3350 +159
==========================================
+ Hits 2557 2687 +130
- Misses 521 548 +27
- Partials 113 115 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Apr 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As OpenTracing (the predecessor to OpenTelemetry) has been deprecated, this change adds support for OpenTelemetry via the
WithOpenTelemetryfunctional option.A lot of the API and options align with the
otelhttptransport that can be used on the net/http clientAddresses issue #249