Allow exclamation mark as valid header character#745
Merged
JakeChampion merged 1 commit intoJakeChampion:masterfrom May 28, 2020
Merged
Allow exclamation mark as valid header character#745JakeChampion merged 1 commit intoJakeChampion:masterfrom
JakeChampion merged 1 commit intoJakeChampion:masterfrom
Conversation
|
+1 on fixing this spec violation |
|
bump, have the same issue with api that sometimes adds a header with a Thanks 👍 |
JakeChampion
approved these changes
May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the section 3.2.6 of the HTTP RFC7230, it denotes the following about HTTP headers:
Note the
tchardefinition allows use of an exclamation mark, but the validator fornormalizeNamedoes not allow it.This PR adds the exclamation mark to the list of allowed characters to header fields.
Verification
Execute the following in the browser console: