Move set_transaction_name out of event processor in fastapi/starlette#1751
Merged
sl0thentr0py merged 1 commit intomasterfrom Nov 22, 2022
Merged
Move set_transaction_name out of event processor in fastapi/starlette#1751sl0thentr0py merged 1 commit intomasterfrom
sl0thentr0py merged 1 commit intomasterfrom
Conversation
839764e to
fcdd19b
Compare
antonpirker
approved these changes
Nov 22, 2022
Contributor
antonpirker
left a comment
There was a problem hiding this comment.
Tested it with my FastAPI demo projects. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing this in the event processor breaks the transaction name contract if the user sets the transaction name manually on scope.