fix(utils): strip_string() checks text length counting bytes not chars#1711
Merged
antonpirker merged 1 commit intogetsentry:masterfrom Oct 27, 2022
Merged
fix(utils): strip_string() checks text length counting bytes not chars#1711antonpirker merged 1 commit intogetsentry:masterfrom
antonpirker merged 1 commit intogetsentry:masterfrom
Conversation
The truncation and indexes in the AnnotatedValues it's done by number of bytes and not number of characters. Fixes getsentryGH-1691
antonpirker
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In this PR I applied the antonpirker suggest. Now the truncation and indexes in the AnnotatedValues it's done by number of bytes and not number of characters.
Thank you!
Fixes GH-1691