Replace Travis CI badge with GitHub Actions badge#1538
Merged
sl0thentr0py merged 2 commits intogetsentry:masterfrom Aug 4, 2022
153957:patch-1
Merged
Replace Travis CI badge with GitHub Actions badge#1538sl0thentr0py merged 2 commits intogetsentry:masterfrom 153957:patch-1
sl0thentr0py merged 2 commits intogetsentry:masterfrom
153957:patch-1
Conversation
Travis CI is no longer being used and has been replaced by GitHub Actions. The ci.yml workflow contains the main tests, so show that status in the README.
Contributor
Author
|
@sl0thentr0py there is still a 'reference' to travis in the actual ci.yml file, creating postgres databases, maybe those should also be renamed? Or removed if they are not even used, I found not other uses of those database names in the code ( https://github.com/getsentry/sentry-python/search?q=travis_ci_test ) https://github.com/getsentry/sentry-python/blob/master/.github/workflows/ci.yml#L98-L99 |
Member
|
hmm yea don't see where they're used, can you remove them? let's see if CI passes. Thanks again! |
These database names do not appear anywhere else in the code and seem unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis CI is no longer being used and has been replaced by GitHub Actions.
The ci.yml workflow contains the main tests, so show that status in the README.