fix: Avoid invalid memory access in the logger#310
Conversation
This also turns on the logger for the HTTP-based tests, and enables more testing of the crashpad backend.
fe0ea7d to
e966dd1
Compare
|
Just tried it, works perfectly 👌. |
There was a problem hiding this comment.
Thanks for the fix! This originated in my comment at #301 (comment), which was written from poor memory about the API without testing it myself.
Are there still tests running without logs? We need to ensure that both paths are properly tested.
Please separate out all unrelated changes to tests into a separate PR, and then let's get this released as 0.3.4 directly on top of 0.3.3. We'll not merge any further features until code coverage is in place, and we run all tests with memory/address sanitizers.
we test both with the standard http transport, with logs, and we also test with a specific stdout transport without logs, since I think that interferes with the way we capture the output, although stderr should be separate. |
4529cf5 to
e457e14
Compare
This also turns on the logger for the HTTP-based tests.
Fixes #309