Conversation
4379bc5 to
dbfd46a
Compare
* run `scan-build` (clang analyzer) on linux (currently only produces warnings) * switch to gcc-10 and clang-10 on linux * run asan leak-check on clang builds on linux
jan-auer
approved these changes
Jun 17, 2020
| CC: gcc-10 | ||
| CXX: g++-10 | ||
| # GCC does not respect the `-Wvariadic-macros` suppression right now | ||
| # ERROR_ON_WARNINGS: 1 |
Member
There was a problem hiding this comment.
How would you feel if we stay on GCC 9 until this is resolved?
Contributor
Author
There was a problem hiding this comment.
If I remember correctly, it had the same problems, lol.
irov
pushed a commit
to irov/sentry-native
that referenced
this pull request
Jun 17, 2020
* run `scan-build` (clang analyzer) on linux (currently only produces warnings) * switch to gcc-10 and clang-10 on linux * run asan leak-check on clang builds on linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scan-build(clang analyzer) on linux (although currently it only produces warnings and not hard errors)