Support for 32 bit linux builds and gcc 4.9#291
Merged
Swatinem merged 3 commits intogetsentry:masterfrom Jun 16, 2020
Merged
Conversation
Mixaill
reviewed
Jun 10, 2020
Swatinem
reviewed
Jun 11, 2020
Contributor
Swatinem
left a comment
There was a problem hiding this comment.
Nice!
We do test for 32-bit GCC7 already:
sentry-native/azure-pipelines.yml
Lines 21 to 23 in 2e73065
sentry-native/tests/__init__.py
Lines 103 to 104 in 2e73065
Would be nice to adapt the code to also do the right thing in this case
3a8dd23 to
0a090df
Compare
Swatinem
reviewed
Jun 11, 2020
Contributor
Swatinem
left a comment
There was a problem hiding this comment.
what I meant concerning the CI setup: can you remove the explicit -m32 flag from the CI config, and rather update the test runner to pass down your newly introduced cmake flag when the TEST_X86 flag is set?
4638273 to
4c36603
Compare
Swatinem
approved these changes
Jun 16, 2020
Co-authored-by: Arpad Borsos <arpad.borsos@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds option to enable 32 bit linux builds when on a 64bit host.
Links librt explicit in test suites (needed by older gcc chains that don't automatically manage it.)