win: Remove use of Windows 8+ API#212
Merged
Swatinem merged 1 commit intogetsentry:masterfrom Apr 1, 2020
Merged
Conversation
Contributor
Author
|
Given that building against the Windows 8.1 SDK is broken with the Crashpad backend, and given that CMake uses that SDK when targeting anything prior to Windows 10, I think more needs to be done in order to enable |
Swatinem
approved these changes
Apr 1, 2020
Contributor
|
Well, I do not have 8.1 SDK installed (only 7.1A (xp toolchain) and 10.0), so all the system versions build fine for me. =\ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the single use of the
PathCchRemoveFileSpecbecause that's a Windows 8+ API and a reasonable alternative that doesn't require newer OS versions is available. Indeed, the newer API is not used in MinGW builds because it's not available there either.With this change, one can now build a Windows 7 (and probably also Windows Vista too) compatible version of Sentry.
Without this change, applications linking against the
sentry-nativelibrary will not run on Windows 7. If one tries to build usingCMAKE_SYSTEM_VERSION=6.1for Windows 7 compatibility, the build fails because CMake selects the Windows SDK 8.1 version and Crashpad won't build against that version of the SDK at all:And if one builds with
CMAKE_SYSTEM_VERSION=10thenPathCchRemoveFileSpecis used unconditionally insentry__path_dirwhich breaks compatibility with Windows 7.