feat: add cache_dir header for external crash reporters#1698
Merged
Conversation
|
External crash reporters only receive the envelope path, so include the cache directory in envelope headers when cache_keep is enabled. This lets capable reporters cache related files without changing the one-argument protocol. Fixes GH-1688 Co-Authored-By: OpenAI Codex <noreply@openai.com>
b6943ef to
2cab8cd
Compare
The native crash daemon loads crash envelopes from disk as raw envelopes. Materialize them before launching an external crash reporter when cache_keep is enabled, so the shared launcher can add the cache_dir header without mutating raw envelopes itself. Refs GH-1688 Co-Authored-By: OpenAI Codex <noreply@openai.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3454003. Configure here.
mujacica
approved these changes
May 6, 2026
Keep sentry__envelope_materialize in-place, but restore the original raw payload when parsing fails. This lets callers warn and continue instead of sending or falling back with a corrupted envelope. Co-Authored-By: OpenAI Codex <noreply@openai.com>
JoshuaMoelans
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External crash reporters only receive the envelope path, so include the cache directory in envelope headers when
cache_keepis enabled. This lets capable reporters cache related files without changing the single-argument CLI protocol.See also: