Generated by 🚫 dangerJS against ce0b2da

@JoshuaMoelans What do you think about <run>/crashpad-handler.log for the handler side, and then either STDERR and/or <run>/crashpad-client.log for the client side. We can pass LOG_TO_STDERR to the client, but then crashpad-client.log becomes kind of redundant.

P.S. Neither of them barely logs almost anything at all. They seem to be mostly errors only.

@jpnurmi yeah that sounds good, it's where I would expect these logs to show up (crashpad being a different process, I also don't mind it not going to STDERR by default either)

@JoshuaMoelans What about the client side that lives in the same process? It can also print useful errors, such as crashpad_handler missing +x on Linux. Here's a fabricated error with crashpad_handler.exe replaced by an empty file:

We can either capture client-side errors into STDERR so that it gets mixed in the sentry output (notice one message from crashpad_client_win.cc in the middle):

[sentry] INFO using database path "C:\Users\jpnurmi\Projects\sentry\sentry-playground\build\.sentry-native"
[sentry] DEBUG starting transport
[sentry] DEBUG starting background worker thread
[sentry] DEBUG submitting 100 ms delayed task to background worker thread
[sentry] DEBUG starting backend
[sentry] DEBUG background worker thread started
[sentry] DEBUG starting crashpad backend with handler "C:\Users\jpnurmi\Projects\sentry\sentry-playground\build\crashpad_handler.exe"
[sentry] DEBUG using minidump URL "https://127.0.0.1:12345/api/1/minidump/?sentry_client=sentry.native/0.13.7&sentry_key=aaa"
[19168:9228:20260420,170017.136:ERROR crashpad_client_win.cc:615] CreateProcess: %1 is not a valid Win32 application. (193)
[sentry] DEBUG registering crashpad WER handler "C:\Users\jpnurmi\Projects\sentry\sentry-playground\build\crashpad_wer.dll"
[sentry] WARN failed to start crashpad client handler
[sentry] WARN failed to initialize backend
[sentry] WARN `sentry_init` failed

Alternatively, we can capture it to <run>/crashpad-client.log:

C:\Users\jpnurmi\Projects\sentry\sentry-playground>type build\.sentry-native\c6a43bc8-2629-492d-e79c-94cb114aff09.run\crashpad-client.log
[19168:9228:20260420,170017.136:ERROR crashpad_client_win.cc:615] CreateProcess: %1 is not a valid Win32 application. (193)

Or, we can combine both so that you get crashpad-client.log and crashpad-handler.log side by side, even if the client-side logs appear in STDERR.

@jpnurmi ah, in that case I think having it as part of the actual debug logs next to the Sentry ones could be helpful when debugging user's issues, since we usually have them send us the debug log outputs (and then having to look through the log file and the console output seems like a bit of double work). I think I misunderstood the client log side of things at first 😅 piping to STDERR sounds good to me!