feat(cache): write .dmp separately alongside .envelope#1607
Merged
Conversation
Store minidump attachments as separate .dmp files in the offline cache for direct debugger access without the need of manually extracting minidumps from envelopes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Move ctx->index++ after the write succeeds so failed writes don't create gaps in the numbering. This ensures foreach_minidump can always find all written .dmp files by stopping at the first miss. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mujacica
approved these changes
Mar 30, 2026
JoshuaMoelans
approved these changes
Mar 30, 2026
1 task
BernhardMarconato
pushed a commit
to elgatosf/sentry-native
that referenced
this pull request
Apr 21, 2026
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store minidump attachments as separate
.dmpfiles in the offline cache for direct debugger access without the need to manually extract minidumps from envelopes.NOTE: The
.envelope+.dmpfiles are treated as a single entity for offline cache limits (cache_max_items,cache_max_size).