Remove compile-time AsynchDNS check#1206
Conversation
|
@supervacuus based on your Issue / PR history this seems like one for you to look at when you get a moment! |
supervacuus
left a comment
There was a problem hiding this comment.
Unfortunately, this is not the proper fix. While 3.29.0 may fix something that rectified the horrible situation in many packaging environments from the CMake side, this would turn off the check for way more users than necessary.
I propose the opposite direction: since a significant portion of users work in a packaging environment, which leads to false negatives (for whatever reason, there seem to be multiple causes) during build time, let's turn off the component check altogether.
As you mentioned in the related issue, there will rarely be a curl installation that doesn't support this feature, and we also have runtime checks during initialization. Since the build check doesn't provide any feedback on the deployment situation anyway, we can remove it and solely rely on the runtime checks.
Please also add a changelog entry.
|
@supervacuus - makes sense! done. |
Resolves #1205
I am not super confident with my
sentry-config.cmake.inchange. Can someone better versed in CMake let me know if that is right?