feat: crashpad support for C++17 compilers.#1110
Conversation
092d889 to
4759af7
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1110 +/- ##
==========================================
- Coverage 82.58% 82.52% -0.07%
==========================================
Files 53 53
Lines 7896 7896
Branches 1234 1234
==========================================
- Hits 6521 6516 -5
- Misses 1265 1268 +3
- Partials 110 112 +2 |
Great! Happy New Year, @JoshuaMoelans. I want to review the changes needed in the forks line-by-line with you before we merge anything. A considerable amount of C++17 and 20 specifics require changing, and I want to ensure these are clear. We also must find a |
|
@JoshuaMoelans, now that we have reviewed it in detail and have a |
JoshuaMoelans
left a comment
There was a problem hiding this comment.
lgtm, the chain seems correct! 🚀
Fixes #1041 by introducing a fork for the transitive
mini_chromiumdependency. For details: getsentry/crashpad#116.