feat: add option to set debug log level#1107
Merged
JoshuaMoelans merged 10 commits intomasterfrom Dec 19, 2024
Merged
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
- Coverage 82.57% 82.49% -0.08%
==========================================
Files 53 53
Lines 7889 7896 +7
Branches 1232 1234 +2
==========================================
Hits 6514 6514
- Misses 1263 1270 +7
Partials 112 112 |
JoshuaMoelans
commented
Dec 18, 2024
JoshuaMoelans
commented
Dec 18, 2024
sentry_init and global logger log levels
supervacuus
requested changes
Dec 18, 2024
Collaborator
supervacuus
left a comment
There was a problem hiding this comment.
I expected the macro name change to highlight a few inconsistencies.
A short sync might also be acceptable regarding the options interface.
sentry_init and global logger log levels
supervacuus
reviewed
Dec 19, 2024
supervacuus
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #888
Related to getsentry/sentry-cocoa#4467
The main goal is to allow for outputting just the warnings from
sentry_init. To accommodate this, we introduce log levels as a way to control what level of output the user gets. We decided against splitting up these levels intoinit-only and global levels, since this doesn't seem like a necessary feature as of yet.